Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce time-consuming of pre-merge #9887

Merged
merged 34 commits into from
Jan 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
2d335d5
add mark
YanxuanLiu Nov 29, 2023
bef78a0
reset
YanxuanLiu Nov 29, 2023
06e149c
skip build only version
YanxuanLiu Nov 29, 2023
3e07145
Merge remote-tracking branch 'upstream/branch-24.02' into rebalance-p…
YanxuanLiu Nov 30, 2023
6250596
Merge branch 'NVIDIA:branch-24.02' into rebalance-premerge-time
YanxuanLiu Nov 30, 2023
c0251c6
Merge remote-tracking branch 'upstream/branch-24.02' into rebalance-p…
YanxuanLiu Nov 30, 2023
cf55d37
Merge branch 'rebalance-premerge-time' of https://github.com/YanxuanL…
YanxuanLiu Nov 30, 2023
d325d70
restore build only steps
YanxuanLiu Nov 30, 2023
9bef297
Merge remote-tracking branch 'upstream/branch-24.02' into rebalance-p…
YanxuanLiu Dec 1, 2023
800b9fa
Merge remote-tracking branch 'upstream/branch-24.02' into rebalance-p…
YanxuanLiu Dec 4, 2023
4ddc584
Merge remote-tracking branch 'upstream/branch-24.02' into rebalance-p…
YanxuanLiu Dec 6, 2023
fad871c
remove nosnapshots
YanxuanLiu Dec 7, 2023
a72493d
remove test file
YanxuanLiu Dec 7, 2023
03d3f05
Merge remote-tracking branch 'upstream/branch-24.02' into rebalance-p…
YanxuanLiu Dec 9, 2023
5f73433
add noSnapshots
YanxuanLiu Dec 9, 2023
d618672
add buildver
YanxuanLiu Dec 14, 2023
5fc9bf0
Merge branch 'NVIDIA:branch-24.02' into rebalance-premerge-time
YanxuanLiu Dec 14, 2023
45c04dc
add pytest mark to delta lake
YanxuanLiu Dec 15, 2023
04c95e1
Merge remote-tracking branch 'upstream/branch-24.02' into rebalance-p…
YanxuanLiu Dec 15, 2023
48e5bd5
Merge branch 'rebalance-premerge-time' of https://github.com/YanxuanL…
YanxuanLiu Dec 15, 2023
68d21b7
comment py mark
YanxuanLiu Dec 18, 2023
63b3b30
Merge branch 'NVIDIA:branch-24.02' into rebalance-premerge-time
YanxuanLiu Dec 18, 2023
3a6d03e
remove test file, add py test mark
YanxuanLiu Dec 18, 2023
1833cd0
Merge branch 'rebalance-premerge-time' of https://github.com/YanxuanL…
YanxuanLiu Dec 18, 2023
202d3d5
Update delta_lake_test.py
YanxuanLiu Dec 19, 2023
5ee3666
add pytest mark for sort
YanxuanLiu Dec 19, 2023
9601a9d
Merge branch 'NVIDIA:branch-24.02' into rebalance-premerge-time
YanxuanLiu Dec 25, 2023
b3f8dff
add property for 2.13
YanxuanLiu Dec 25, 2023
c548fd4
add pytest mark to conditionals test
YanxuanLiu Dec 26, 2023
3aecba1
Merge branch 'NVIDIA:branch-24.02' into rebalance-premerge-time
YanxuanLiu Dec 26, 2023
e3074f5
Merge branch 'NVIDIA:branch-24.02' into rebalance-premerge-time
YanxuanLiu Dec 28, 2023
7d94c79
Merge branch 'NVIDIA:branch-24.02' into rebalance-premerge-time
YanxuanLiu Jan 2, 2024
854fa85
move build only step out of loop
YanxuanLiu Jan 2, 2024
1e0b1c1
move timezone tests to mvn_verify
YanxuanLiu Jan 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dist/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@
</profile>
<profile>
<id>pre-merge</id>
<properties>
<included_buildvers>${buildver}</included_buildvers>
</properties>
<build>
<plugins>
<plugin>
Expand Down
3 changes: 3 additions & 0 deletions integration_tests/src/main/python/conditionals_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
from marks import datagen_overrides, allow_non_gpu
import pyspark.sql.functions as f

# mark this test as ci_1 for mvn verify sanity check in pre-merge CI
pytestmark = pytest.mark.premerge_ci_1

def mk_str_gen(pattern):
return StringGen(pattern).with_special_case('').with_special_pattern('.{0,10}')

Expand Down
3 changes: 3 additions & 0 deletions integration_tests/src/main/python/sort_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
import pyspark.sql.functions as f
from spark_session import is_before_spark_340

# mark this test as ci_1 for mvn verify sanity check in pre-merge CI
pytestmark = pytest.mark.premerge_ci_1

# Many Spark versions have issues sorting decimals.
# https://issues.apache.org/jira/browse/SPARK-40089
_orderable_not_null_big_decimal_gen = DecimalGen(precision=20, scale=2, nullable=False)
Expand Down
26 changes: 14 additions & 12 deletions jenkins/spark-premerge-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,12 @@ mvn_verify() {
$MVN_CMD -B $MVN_URM_MIRROR -Dbuildver=$version test -rf tests $MVN_BUILD_ARGS -Dpytest.TEST_TAGS='' \
-DwildcardSuites=org.apache.spark.sql.rapids.filecache.FileCacheIntegrationSuite
# build only for other versions
elif [[ "${SPARK_SHIM_VERSIONS_NOSNAPSHOTS_TAIL[@]}" =~ "$version" ]]; then
$MVN_INSTALL_CMD -DskipTests -Dbuildver=$version
# elif [[ "${SPARK_SHIM_VERSIONS_NOSNAPSHOTS_TAIL[@]}" =~ "$version" ]]; then
# $MVN_INSTALL_CMD -DskipTests -Dbuildver=$version
fi
done
# build base shim version for following test step with PREMERGE_PROFILES
$MVN_INSTALL_CMD -DskipTests -Dbuildver=$SPARK_BASE_SHIM_VERSION

# enable UTF-8 for regular expression tests
for version in "${SPARK_SHIM_VERSIONS_PREMERGE_UTF8[@]}"
Expand Down Expand Up @@ -95,6 +97,15 @@ mvn_verify() {

# Triggering here until we change the jenkins file
rapids_shuffle_smoke_test

# Test a portion of cases for non-UTC time zone because of limited GPU resources.
# Here testing: parquet scan, orc scan, csv scan, cast, TimeZoneAwareExpression, FromUTCTimestamp
# Nightly CIs will cover all the cases.
source "$(dirname "$0")"/test-timezones.sh
for tz in "${time_zones_test_cases[@]}"
do
TZ=$tz ./integration_tests/run_pyspark_from_build.sh -m tz_sensitive_test
done
}

rapids_shuffle_smoke_test() {
Expand Down Expand Up @@ -157,15 +168,6 @@ ci_2() {
prepare_spark $SPARK_VER 2.12
./integration_tests/run_pyspark_from_build.sh

# Test a portion of cases for non-UTC time zone because of limited GPU resources.
# Here testing: parquet scan, orc scan, csv scan, cast, TimeZoneAwareExpression, FromUTCTimestamp
# Nightly CIs will cover all the cases.
source "$(dirname "$0")"/test-timezones.sh
for tz in "${time_zones_test_cases[@]}"
do
TZ=$tz ./integration_tests/run_pyspark_from_build.sh -m tz_sensitive_test
done

# enable avro test separately
INCLUDE_SPARK_AVRO_JAR=true TEST='avro_test.py' ./integration_tests/run_pyspark_from_build.sh
# export 'LC_ALL' to set locale with UTF-8 so regular expressions are enabled
Expand Down Expand Up @@ -239,7 +241,7 @@ nvidia-smi

. jenkins/version-def.sh

PREMERGE_PROFILES="-PnoSnapshots,pre-merge"
PREMERGE_PROFILES="-Ppre-merge"

# If possible create '~/.m2' cache from pre-created m2 tarball to minimize the impact of unstable network connection.
# Please refer to job 'update_premerge_m2_cache' on Blossom about building m2 tarball details.
Expand Down
3 changes: 3 additions & 0 deletions scala2.13/dist/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@
</profile>
<profile>
<id>pre-merge</id>
<properties>
<included_buildvers>${buildver}</included_buildvers>
</properties>
<build>
<plugins>
<plugin>
Expand Down