Params for build and test CI scripts on Databricks #9904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix NVIDIA#9903 Add params to support specify build, test args on Databricks for CI scripts, e.g. `python jenkins/databricks/run-build.py -e SKIP_DEP_INSTALL=1` : Run maven build on Databricks and skip installing dependencies into maven repo `python jenkins/databricks/run-test.py -e TEST_MODE=DELTA_LAKE_ONLY` : only run Delta Lake test cases on Databricks Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
pxLi
as code owners
jlowe
previously approved these changes
Nov 30, 2023
tgravescs
reviewed
Nov 30, 2023
tgravescs
previously approved these changes
Nov 30, 2023
|
Is there a way to test this from blossom |
pxLi
previously approved these changes
Dec 1, 2023
Yes verified it from dev pipeline, I'll add a parameter(e.g. |
Signed-off-by: Tim Liu <timl@nvidia.com>
|
build |
|
pre-merge failed #9916 |
|
build |
|
re-kicked after merging the fix |
pxLi
approved these changes
Dec 1, 2023
tgravescs
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Params for build and test CI scripts on Databricks
To fix #9903
Add params to support specify build, test args on Databricks for CI scripts, e.g.
python jenkins/databricks/run-build.py -e SKIP_DEP_INSTALL=1: Run maven build on Databricks and skip installing dependencies into maven repopython jenkins/databricks/run-test.py -e TEST_MODE=DELTA_LAKE_ONLY: only run Delta Lake test cases on DatabricksSigned-off-by: timl@nvidia.com