-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register default allocator for host memory #9908
Conversation
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
build |
1 similar comment
build |
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
build |
build |
@@ -163,6 +163,9 @@ private class HostAlloc(nonPinnedLimit: Long) extends HostMemoryAllocator with L | |||
var allocAttemptFinishedWithoutException = false | |||
try { | |||
do { | |||
if (retryCount > 0) { | |||
logWarning(s"RETRY HOST ALLOC $amount $preferPinned $blocking $retryCount") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you want to leave this as warn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This gets us to a point where we can have CUDF java allocating host memory through HostAlloc. But it is not 100% perfect yet. Test pass, but the integration tests appear to have a live lock in them that I need to track down when running with limited memory. It should still be good for us to get started working on other HostMemoryLimit issues.