Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSD-1751: Adding interaction tests for Slider component #1624

Merged
merged 3 commits into from
Jun 21, 2024
Merged

DSD-1751: Adding interaction tests for Slider component #1624

merged 3 commits into from
Jun 21, 2024

Conversation

EdwinGuzman
Copy link
Member

Fixes JIRA ticket DSD-1751

This PR does the following:

  • Adds interaction tests for the Slider component. Check both variants for the regular and "range" slider.

How has this been tested?

Storybook

Accessibility concerns or updates

  • n/a

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@EdwinGuzman EdwinGuzman added the Needs Review Pull requests that are ready for peer review. label Jun 18, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 4:44pm

bigfishdesign13
bigfishdesign13 reviewed Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@bigfishdesign13 bigfishdesign13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests that you have look good, but it ispossible to also add events using tab and the left/right arrows to move the slider?

@EdwinGuzman
Copy link
Member Author

@bigfishdesign13 yes, added.

bigfishdesign13
bigfishdesign13 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@bigfishdesign13 bigfishdesign13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Please note, however, that there is an issue in CI / Test.

@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed Needs Review Pull requests that are ready for peer review. labels Jun 20, 2024
@EdwinGuzman EdwinGuzman merged commit 75340ac into development Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigfishdesign13 bigfishdesign13 bigfishdesign13 approved these changes

@jackiequach jackiequach Awaiting requested review from jackiequach

@oliviawongnyc oliviawongnyc Awaiting requested review from oliviawongnyc

@7emansell 7emansell Awaiting requested review from 7emansell

Assignees
No one assigned
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwinGuzman @bigfishdesign13