jest routing npm package update #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwinGuzman
requested review from
bigfishdesign13,
jackiequach,
oliviawongnyc and
7emansell
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "jest-axe": "5.0.1", | ||
| "jest-environment-jsdom": "29.5.0", | ||
| "jest": "29.7.0", | ||
| "jest-axe": "9.0.0", |
There was a problem hiding this comment.
This is a big jump. Are there any concerns?
There was a problem hiding this comment.
I had some concerns regarding the WCAG standard being used and our tests breaking but no, it was seamless. We should update this though because this updates the min node version to 16.
| @@ -76,7 +76,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/core": "7.14.6", | |||
| "@jest/core": "27.3.1", | |||
| "@jest/core": "29.7.0", | |||
There was a problem hiding this comment.
Jmping up two major versions. Any concerns?
There was a problem hiding this comment.
No, there are bug fixes and some improvements but no breaking changes.
bigfishdesign13
approved these changes
Jun 21, 2024
bigfishdesign13
added
Ship It
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
How has this been tested?
Locally.
Accessibility concerns or updates
Checklist:
Front End Review: