-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSD-1746: FeedbackBox interaction tests #1628
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to get tests for the other fields but I'm not sure if you can rerender the component and set showCategoryField
and showEmailField
to true. Maybe those should be set to true for storybook, but that can be separate and a later step.
@@ -1,6 +1,7 @@ | |||
import { Box } from "@chakra-ui/react"; | |||
import type { Meta, StoryObj } from "@storybook/react"; | |||
import { useState } from "react"; | |||
import { userEvent, expect, screen } from "@storybook/test"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not know you can get the mounted DOM directly from the package. I've been doing const screen = within(canvasElement);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, something to remember for Modal
for sure bc screen
here is not the same as within(canvasElement)
@bigfishdesign13 I think we've done this before with the |
@7emansell Yes, I think that would be fine to set @EdwinGuzman The next release is next Thursday, so there would be time to tackle this change as part of this ticket. |
Fixes JIRA ticket DSD-1746
This PR does the following:
FeedbackBox
componentHow has this been tested?
Accessibility concerns or updates
Checklist:
Front End Review: