DSD-1798: Add labelPlacement prop to ProgressIndicator #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackiequach
requested review from
EdwinGuzman,
bigfishdesign13,
oliviawongnyc and
7emansell
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EdwinGuzman
reviewed
Oct 4, 2024
| @@ -95,7 +99,7 @@ export const ProgressIndicator: ChakraComponent< | |||
| if (indicatorType === "circular") { | |||
| // For the small size, since the label won't be visible, we need to add | |||
There was a problem hiding this comment.
I don't think this comment is true anymore since the circular small size variant does display the label on the right side.
| @@ -107,8 +111,14 @@ export const ProgressIndicator: ChakraComponent< | |||
| </ChakraCircularProgressLabel> | |||
| )} | |||
| </ChakraCircularProgress> | |||
| {showLabel && size !== "small" && ( | |||
| <Label id={`${id}-label`} htmlFor={id}> | |||
| {showLabel && (size !== "small" || labelPlacement === "right") && ( | |||
There was a problem hiding this comment.
Can you add a few more examples in the storybook doc section? The current example shows size="small" and labelPlacement="right", but it'd be good to see others such as the regular size and labelPlacement="right".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIRA ticket DSD-1798
This PR does the following:
labelPlacementprop to theProgressIndicatorcomponent to allow users to set the placement of labels relative to the indicator. It is only applicable to the circular variant.How has this been tested?
Accessibility concerns or updates
Accessibility Checklist
aria-liveis used, a screenreader was used to verify the text is read.refs, focus management was reviewed.Open Questions
Checklist:
Front End Review: