Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating GIFs from Ugoira fails when deletezipfile = True #838

Closed
2 tasks done
Rocky-sama opened this issue Oct 24, 2020 · 3 comments
Closed
2 tasks done

Creating GIFs from Ugoira fails when deletezipfile = True #838

Rocky-sama opened this issue Oct 24, 2020 · 3 comments

Comments

@Rocky-sama
Copy link

Prerequisites

  • Did you read FAQ section?
  • Did you test with the latest releases or commit ?

Description

I ran the 20200525 release until now so I had to start using ffmpeg with the latest release.
This however gives me an error that it couldn't find the zip file that contains all the single images.
To me it seems like a problem with the workflow, meaning that the zip file is deleted before ffmpeg is done with the conversion to GIF.

My workaround is setting deletezipfile = False but I don't want to have the zip files of all animations lying around.

Maybe the issues #799 and #818 are related.

Steps to Reproduce

  1. Set config.ini settings to

[FFmpeg]
ffmpeg = ffmpeg
ffmpegcodec = libvpx-vp9
ffmpegext = webm
ffmpegparam = -lossless 1 -vsync 2 -r 999 -pix_fmt yuv420p
webpcodec = libwebp
webpparam = -lossless 0 -q:v 90 -loop 0 -vsync 2 -r 999

[Ugoira]
writeugoirainfo = False
createugoira = True
deletezipfile = True
creategif = True
createapng = False
deleteugoira = True
createwebm = False
createwebp = False

  1. Download an Ugoira file

Expected behavior:
Successfully download the Ugoira and only have an animated GIF remaining

Actual behavior:
Error message FileNotFoundError: [Errno 2] No such file or directory: 'E:\[...]\pixivutil20201019-beta4\[user] ([user_id])\[img_id]_ugoira1920x1080 [...].zip' leaving me only with the choice of closing the application.
The .ugoira file isn't deleted.

Versions

v20201019-beta4

You can get this information from executing PixivUtil2.py --help.
Latest version available in https://github.com/Nandaka/PixivUtil2/releases

@Nandaka
Copy link
Owner

Nandaka commented Oct 24, 2020

can you upload the log file?

EDIT: there is a config to delete ugoira, need to add check if already deleted or not

@Rocky-sama
Copy link
Author

For some reason it works now. I tried it again with multiple situations (downloading directing with image_id or from bookmarked artists) and it doesn't fail anymore.

The whole log file is bloated and contains my email address so I hope an excerpt is enough: logfile.txt

I can't reproduce it so if that's good enough for you, you can close the issue...

@Nandaka
Copy link
Owner

Nandaka commented Oct 24, 2020

added some changes to avoid deletion order, should be fixed edge cases now.

35122 pushed a commit to 35122/PixivUtil2 that referenced this issue Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants