PixivHelper.sanitize_filename(): correctly cutting filename on linux #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cutting filename to <= 249 bytes in UTF8 on Linux environment. For fixing Nandaka#525 For Linux, 255 bytes is the maximum for filename (not full path). And almost all Linux environments use UTF-8 for path encoding. And the path is used later with suffix ".pixiv" (consume 6 bytes). So 249 bytes is maybe a minimum. https://github.com/Nandaka/PixivUtil2/blob/dbb810716c4824724c03ce8e022a5b5d31f41800/PixivHelper.py#L590 Windows/Mac isn't affected.
35122
pushed a commit
to 35122/PixivUtil2
that referenced
this pull request
Oct 30, 2020
…andaka#617) Cutting filename to <= 249 bytes in UTF8 on Linux environment. For fixing Nandaka#525 For Linux, 255 bytes is the maximum for filename (not full path). And almost all Linux environments use UTF-8 for path encoding. And the path is used later with suffix ".pixiv" (consume 6 bytes). So 249 bytes is maybe a minimum. https://github.com/Nandaka/PixivUtil2/blob/dbb810716c4824724c03ce8e022a5b5d31f41800/PixivHelper.py#L590 Windows/Mac isn't affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cutting filename to <= 249 bytes in UTF8 on Linux environment.
For fixing #525
For Linux, 255 bytes is the maximum for filename (not full path).
And almost all Linux environments use UTF-8 for path encoding.
And the path is used later with suffix ".pixiv" (consume 6 bytes).
So 249 bytes is maybe a minimum.
PixivUtil2/PixivHelper.py
Line 590 in dbb8107
Windows/Mac isn't affected.