Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to PixivFanboxHandler, PixivUtil2, readme #763

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Minor changes to PixivFanboxHandler, PixivUtil2, readme #763

merged 3 commits into from
Aug 14, 2020

Conversation

bluerthanever
Copy link
Contributor

  1. Commented config.loadConfig(path=caller.configfile) inside process_fanbox_post
  • I don't think it's necessary to read config for each post. For each artist? Maybe, as some users requested.
  1. In PixivUtil2, moved del post into the try... except... before it in menu_fanbox_download_by_post_id
  2. Some grammatical adjustments in readme

@bluerthanever
Update PixivFanboxHandler.py
c2f9e79 
Commented codes to read config for every FANBOX post.
@bluerthanever
Update readme.md
768efb3 
Grammatical adjustments
@bluerthanever
Update PixivUtil2.py
252e557 
Moved `del post` into the `try... except...` before it.
@Nandaka Nandaka merged commit 9147535 into Nandaka:master Aug 14, 2020
35122 pushed a commit to 35122/PixivUtil2 that referenced this pull request Oct 30, 2020
@bluerthanever
Minor changes to PixivFanboxHandler, PixivUtil2, readme (Nandaka#763)
f552987 
* Update PixivFanboxHandler.py

Commented codes to read config for every FANBOX post.

* Update readme.md

Grammatical adjustments

* Update PixivUtil2.py

Moved `del post` into the `try... except...` before it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluerthanever @Nandaka