Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"any language" search setting not remembered #552

Closed
osma opened this issue Sep 29, 2016 · 2 comments
Closed

"any language" search setting not remembered #552

osma opened this issue Sep 29, 2016 · 2 comments
Labels
Milestone

Comments

@osma
Copy link
Member

osma commented Sep 29, 2016

At which URL did you encounter the problem?

http://finto.fi/fi/

What steps will reproduce the problem?

  1. Select the vocabularies Allärs and YSA, and "any language"
  2. Search for something e.g. "katt", press Enter to get the search result page
  3. Click on the first result to get to the concept page
  4. Click the logo to get to the front page

What is the expected output? What do you see instead?

Expected that the search language setting would be preserved, so that subsequent searches would still target all languages. Instead it changes to Finnish or Swedish on step 3 and remains so in step 4.

What browser did you use? (eg. Firefox, Chrome, Safari, Internet explorer)

Firefox, Chrome

@osma osma added the bug label Sep 29, 2016
@osma osma added this to the 1.8 milestone Sep 29, 2016
@osma
Copy link
Member Author

osma commented Sep 29, 2016

Possible solution: Keep the anylang parameter (for global search) in a cookie, similar to how the selection of vocabularies is remembered

henriyli pushed a commit that referenced this issue Sep 29, 2016
@osma
Copy link
Member Author

osma commented Sep 29, 2016

The problem with this implementation is that it now relies on cookies on the server side, which may mean that a different HTML response is returned for the same URL (depending on the cookie value). This is bad for caching, we have previously tried to avoid this situation. It would be better to check the cookie value in JavaScript code only and set the language selection accordingly on the client side. The server would just see the URL parameter anylang as before.

@osma osma reopened this Sep 29, 2016
henriyli pushed a commit that referenced this issue Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant