Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1018 by explicitly declaring the UI locale in getDate() #1024

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

kouralex
Copy link
Contributor

@kouralex kouralex commented Jul 2, 2020

This PR fixes #1018 by declaring the UI locale in the getDate() method. This could, however, also be fixed by changing the signature of the method and passing the UI language parameter from the Twig template and, thus, making it more versatile, but because the method is not in use in anywhere else it can be fixed straightaway in code.

@kouralex kouralex added this to the Next Tasks milestone Jul 2, 2020
@kouralex kouralex requested a review from osma July 2, 2020 10:11
@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell C 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #1024 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1024      +/-   ##
============================================
- Coverage     60.32%   60.31%   -0.02%     
+ Complexity     1593     1591       -2     
============================================
  Files            32       32              
  Lines          4429     4427       -2     
============================================
- Hits           2672     2670       -2     
  Misses         1757     1757              
Impacted Files Coverage Δ Complexity Δ
model/Concept.php 79.70% <100.00%> (-0.10%) 196.00 <0.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e09706...e90558c. Read the comment docs.

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simpler fix looks good. I've verified that it works locally. +1 for merging.

@osma osma merged commit bc93b5c into master Aug 31, 2020
@osma
Copy link
Member

osma commented Aug 31, 2020

I decided not to wait for @kouralex and just went ahead and merged this. Thanks!

@osma osma deleted the issue1018-timestamp-in-UI-language branch August 31, 2020 14:11
@osma osma modified the milestones: Next Tasks, 2.8 Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp date format should be based on UI language, not content language
2 participants