Improve ajax behavior; miscellanneous fixes #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t aborting of unnecessary requests; fix issue with plugin-induced content appended whilst ajaxing
…uced bug in another ajax request
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1026 +/- ##
=========================================
Coverage 67.90% 67.90%
Complexity 1583 1583
=========================================
Files 32 32
Lines 3889 3889
=========================================
Hits 2641 2641
Misses 1248 1248 Continue to review full report at Codecov.
|
joelit
reviewed
Mar 11, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
kouralex
added a commit
that referenced
this pull request
Mar 11, 2021
kouralex
added a commit
that referenced
this pull request
Mar 11, 2021
…rtifact fix merge conflict regression related to PR #1026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes/implements the following:
However, there remains more to be done, e.g., enabling the usage of ajax requests in cases such as clicking a concept on content page, clicking vocabulary title, moving back/forth search and content pages, clicking hierarchy causes an extra page load in some circumstances, etc. Similarly, much of the code could and should be refactored - no need for duplicate code.