Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dead code: the renderPropertyMappingValues function is never used #1051

Merged
merged 1 commit into from
Sep 2, 2020
Merged

remove dead code: the renderPropertyMappingValues function is never used #1051

merged 1 commit into from
Sep 2, 2020

Conversation

osma
Copy link
Member

@osma osma commented Sep 2, 2020

While working on #1046 I noticed that the renderPropertyMappingValues function is never called. This PR removes it.

@osma osma added the bug label Sep 2, 2020
@osma osma added this to the 2.8 milestone Sep 2, 2020
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kinow
kinow approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick search, used a , then case insensitive, nothing. Looks good!

@osma osma merged commit 5fb7bf7 into master Sep 2, 2020
@osma osma deleted the fix-remove-dead-renderpropertymappings branch September 2, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
2 participants
@osma @kinow