Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update twig; references #918 #1053

Merged
merged 1 commit into from
Sep 7, 2020
Merged

update twig; references #918 #1053

merged 1 commit into from
Sep 7, 2020

Conversation

kouralex
Copy link
Contributor

@kouralex kouralex commented Sep 3, 2020

This PR will update Twig to the latest 2.13.x series. This will enable one to use any new features added to Twig after 2.4.x, including better whitespace control, see https://twig.symfony.com/doc/2.x/templates.html#whitespace-control for more information. This makes it possible to, in the future, cut one-liners into multiple lines.

This PR will not, however, correct any newly deprecated Twig features used in code. This will be left for future 3.x upgrade.

@kouralex kouralex requested a review from osma September 3, 2020 09:50
@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1053 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1053   +/-   ##
=========================================
  Coverage     60.31%   60.31%           
  Complexity     1591     1591           
=========================================
  Files            32       32           
  Lines          4427     4427           
=========================================
  Hits           2670     2670           
  Misses         1757     1757           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb7bf7...693d179. Read the comment docs.

@kouralex kouralex requested a review from joelit September 3, 2020 10:41
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kouralex kouralex merged commit 9cd378c into master Sep 7, 2020
@kouralex kouralex deleted the issue918-update-twig branch September 8, 2020 18:18
@osma osma added this to the 2.8 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants