Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations for w3c geo latitude and longitude, expose vocabulary short name #1081

Merged
merged 16 commits into from
Feb 5, 2021

Conversation

kouralex
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #1081 (a01c9e1) into master (299ee49) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1081      +/-   ##
============================================
- Coverage     60.32%   60.27%   -0.06%     
  Complexity     1592     1592              
============================================
  Files            32       32              
  Lines          4429     4433       +4     
============================================
  Hits           2672     2672              
- Misses         1757     1761       +4     
Impacted Files Coverage Δ Complexity Δ
model/GlobalConfig.php 85.58% <0.00%> (-1.58%) 51.00 <0.00> (ø)
model/sparql/GenericSparql.php 67.93% <52.17%> (-0.12%) 318.00 <0.00> (ø)
model/ConceptPropertyValue.php 87.95% <100.00%> (ø) 47.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299ee49...a01c9e1. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kouralex kouralex requested a review from osma February 2, 2021 22:24
@kouralex kouralex marked this pull request as ready for review February 2, 2021 22:25
@kouralex
Copy link
Contributor Author

kouralex commented Feb 2, 2021

This PR looks a bit odd after rebasing (I thought I did it right but it seems like there was an existing (old) PR (which is this)) but the real comparison can be found here: https://github.com/NatLibFi/Skosmos/compare/geographical-translations.

Reverted a change that made exposed vocabulary short name content language-aware (not shown in commit stack). Also switched from geo prefix into wgs84 which should be 100% explicit.

@kouralex kouralex changed the title add preliminary translations for w3c geo latitude and longitude translations for w3c geo latitude and longitude, expose vocabulary short name Feb 2, 2021
@joelit joelit merged commit ec68c43 into master Feb 5, 2021
@osma osma deleted the geographical-translations branch February 17, 2021 14:09
@miguelvaara miguelvaara modified the milestones: Next Tasks, 2.9 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants