Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EasyRdf to version 1.1.* #1128

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Upgrade EasyRdf to version 1.1.* #1128

merged 2 commits into from
Mar 4, 2021

Conversation

osma
Copy link
Member

@osma osma commented Mar 3, 2021

This PR upgrades EasyRdf to version 1.1.* (currently 1.1.1)
The only Skosmos code change, apart from changing the dependency, was to change two fields in SkosmosTurtleParser from private to protected, to avoid compiler errors.

Upgrading is required to make progress on issue #920 / PR #1127, since the old EasyRdf version we were using is not compatible with PHP 7.4.

@osma osma added this to the 2.10 milestone Mar 3, 2021
@osma osma self-assigned this Mar 3, 2021
@osma
Copy link
Member Author

osma commented Mar 3, 2021

Hmm, I think that actually SkosmosTurtleParser could now be simplified, since the changes to make the parser more efficient were merged into EasyRdf long ago and they are now in the 1.1.1 version we are upgrading to...

@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #1128 (1720e43) into master (6a01b70) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1128      +/-   ##
============================================
+ Coverage     60.30%   60.39%   +0.09%     
+ Complexity     1600     1583      -17     
============================================
  Files            32       32              
  Lines          4436     4376      -60     
============================================
- Hits           2675     2643      -32     
+ Misses         1761     1733      -28     
Impacted Files Coverage Δ Complexity Δ
model/SkosmosTurtleParser.php 100.00% <ø> (+45.16%) 1.00 <0.00> (-17.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a01b70...1720e43. Read the comment docs.

@kouralex
Copy link
Contributor

kouralex commented Mar 4, 2021

Perfect! It is a bit sad that we still need SkosmosTurtleParser as the parsed namespaces are not public. The only way I can think of is to save a reference to the parser object itself in GlobalConfig and call it directly but I guess that does not make much sense..

Anyways, will gladly merge! Very nice upgrade and needed, indeed! :)

@kouralex kouralex merged commit 58ea007 into master Mar 4, 2021
@kouralex kouralex deleted the upgrade-easyrdf-1.1 branch March 4, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants