Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topbar-container css hook #1159

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

danmichaelo
Copy link
Contributor

At the moment I'm not sure if it's possible to make the frontpage topbar look the same as the topbar on other pages with just CSS, since the outer div is missing on the frontpage.

This PR adds an outer div to the frontpage topbar, which makes it easier to style the frontpage topbar as you like. I've added a class name "topbar-container", but otherwise kept the old class names, so I wouldn't expect this change to break anyone's CSS.

Frontpage

+ <div class="topbar-container topbar-frontpage">
    <div class="topbar frontpage">

Non-frontpage

- <div class="topbar-white">
+ <div class="topbar-container topbar-white">
    <div class="topbar topbar-white">

Makes it possible to have the same toolbar on all pages by just adding
custom css, not having to edit the template.
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1159 (f988ad2) into master (4a050f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1159   +/-   ##
=========================================
  Coverage     67.97%   67.97%           
  Complexity     1584     1584           
=========================================
  Files            32       32           
  Lines          3888     3888           
=========================================
  Hits           2643     2643           
  Misses         1245     1245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a050f4...f988ad2. Read the comment docs.

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me and doesn't break the Finto layout which is obviously a plus ;)

@osma osma merged commit 55358c2 into NatLibFi:master Jun 2, 2021
@osma osma added this to the 2.11 milestone Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants