Replace NBSP by spaces #1207
Merged
Replace NBSP by spaces #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
|
Good catch @kinow ! I take it that you searched for NBSP characters in the full codebase and these were the only occurrences? |
There were two other, but in those i18n files (.po?). Couldn't tell if the files were generated via that transifex scropt or if I could change them. |
|
OK, let's leave those for later. Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reading the code, searching for language label/value, and noticed the
NBSPcharacter. It's not really a space char, although most browsers/IDE's support it, it can still cause issues when refactoring with a regex like\sfor instance.The GitHub UI will show like a space. But if you open on PhpStorm, or
vim(clickGfollowed byAto show the current char code in the status bar ofvim) you should be able to see the char.