Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move allcaps in property-labels (and vocabulary-category) from twig to css #1223

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

schlawiner
Copy link
Contributor

Making the changes discussed in issue #1222: removing |upper and toUpperCase from twig files to make these labels regular case again, then adding the relevant classes to styles.css and using text-transform: uppercaseon them.

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma
Copy link
Member

osma commented Oct 15, 2021

Thanks! This needs to be tested before merging, but initially looks very good!

@miguelvaara miguelvaara merged commit 23a2b23 into NatLibFi:master Nov 3, 2021
@miguelvaara
Copy link
Contributor

Tested with a local installation of Skosmos and looks to be working fine. Thank you very much @schlawiner 👍

@miguelvaara miguelvaara added this to the 2.13 milestone Nov 3, 2021
@miguelvaara
Copy link
Contributor

Screenshot from 2021-11-03 12-02-22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility improvement: Remove hardcoding of allcaps label styling, move to CSS
3 participants