Fix hierarchy js error for special characters in prefLabels #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks a lot @schlawiner - this is perfect. I tested it with the UNESCO Thesaurus and this indeed fixes the problems with the hierarchy display of top level concepts. There may still be additional cases that are broken, where a similar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1221.
The trouble was that in one place when building the tree, the getLabel function wasn't used to create the html for notation and preflabel. The getLabel function unescapes special characters in labels and also adds a .tree-label class to the label span, which is later filtered for when sorting the tree in naturalCompare - if it doesn't exist, the variable it depends on isn't filled and the whole thing breaks down.
Lines 221 and 222 are removed because a) the same thing is done in getLabel, and 2) because it didn't escape special chars and doesn't add the .tree-label class that getLabel does.