Allow plugin robloach/component-installer, because it is required by components/handlebars.js #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependency (#1) * Allow plugin robloach/component-installer, because it is required by components/handlebars.js * Adding /.idea to .gitignore so project can be edited in IntelliJ * Removed .idea files from PR * newline at end of .gitignore
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for the PR! I will add this to the next release. :) |
Closed
|
This PR was merged to |
This was referenced Mar 2, 2022
|
Created a new PR (#1280) from the commits of this one to be merged in the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
When running
composer install --no-devI get a question about whether to trust the robloach/component-installer plug-in. Incomposer.jsonit is mentioned as a requirement forcomponents/handlebars.js.robloach/component-installeris deprecated ("abandoned") but I know too little about PHP to solve this in a cleaner way. Hopefully, a new version of handlebars will use the new plug-in https://packagist.org/packages/oomphinc/composer-installers-extender.The interactive part of the installation is incovenient because I am using Ansible to do the installation.
Link to relevant issue(s), if any
n/a
Description of the changes in this PR
composer.json/.ideato.gitignoreas a convenience for people like myself who edit the project in IntelliJ.Known problems or uncertainties in this PR
As far as I understand the only change that this PR applies is that the user who executes the
composer installcommand is not longer asked whether to trust therobloach/component-installerplug-in. However, currently there is no real choice.Checklist
don't know how to run these, but I haven't changed any PHP code, so I would be suprised if they don't pass anymore.
not sure how to do that