Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor CSS tweaks after Bootstrap 5 update #1321

Merged
merged 1 commit into from
May 5, 2022

Conversation

osma
Copy link
Member

@osma osma commented May 5, 2022

Reasons for creating this PR

Fix some minor layout issues found after the Bootstrap 5 update (PR #1182) by @kinow .

Link to relevant issue(s), if any

Description of the changes in this PR

  • adjust text size for the language selection (dropdown style selector)
  • make sure the "from all vocabularies" choice wraps so part of the text is not obscured
  • decrease the size of the placeholder text on the feedback form
  • tweak the vertical alignment of the copy to clipboard icon to make @MikkoAleksanteri happy

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the bug label May 5, 2022
@osma osma added this to the 2.15 milestone May 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1321 (8ce0bc1) into master (566ad4b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1321   +/-   ##
=========================================
  Coverage     70.68%   70.68%           
  Complexity     1646     1646           
=========================================
  Files            32       32           
  Lines          3786     3786           
=========================================
  Hits           2676     2676           
  Misses         1110     1110           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566ad4b...8ce0bc1. Read the comment docs.

@joelit joelit self-requested a review May 5, 2022 14:10
Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I could follow the differences in my browser (Chromium), looks fine to me.

Although I noticed a bug while testing, that just shows there's still tweaking to do with the new Bootstrap:
Screenshot from 2022-05-05 17-05-36

@osma osma merged commit a14435f into master May 5, 2022
@osma osma deleted the fix-css-tweaks-after-bootstrap-5 branch May 5, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants