Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the feature request template with additional instructions #1419

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

osma
Copy link
Member

@osma osma commented Mar 10, 2023

Reasons for creating this PR

The new feature request template has now been used for a couple of months. It has led to better structure in enhancement issues, but there is room for improvement. In particular, the "Who are the users that would benefit" question is often answered with phrases like "Users who would like to..." which isn't really what we were looking for when we created the template.

Link to relevant issue(s), if any

n/a

Description of the changes in this PR

Add some extra information into the feature request template, trying to evoke better answers.

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a22b389) 69.55% compared to head (d4fffc4) 69.55%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1419   +/-   ##
=========================================
  Coverage     69.55%   69.55%           
  Complexity     1650     1650           
=========================================
  Files            32       32           
  Lines          4257     4257           
=========================================
  Hits           2961     2961           
  Misses         1296     1296           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osma osma merged commit 6f51a65 into master Mar 23, 2023
@osma osma added this to the 2.17 milestone Mar 23, 2023
@osma osma self-assigned this Mar 23, 2023
@osma osma deleted the feature-request-instructions branch August 22, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

1 participant