Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The first version of translation functionality in Vue templates, whe… #1662

Draft
wants to merge 1 commit into
base: issue1527-translation-symfony
Choose a base branch
from

Conversation

miguelvaara
Copy link
Contributor

…re translations are visible in the browser and the translation is read at the correct point in the code

Reasons for creating this PR

Link to relevant issue(s), if any

  • Closes #

Description of the changes in this PR

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

…re translations are visible in the browser and the translation is read at the correct point in the code
Copy link

sonarcloud bot commented Aug 21, 2024

@miguelvaara miguelvaara self-assigned this Aug 21, 2024
@miguelvaara miguelvaara added this to the 3.0 milestone Aug 21, 2024
@osma osma changed the title The first version of translation functionality in Twig templates, whe… The first version of translation functionality in Vue templates, whe… Aug 22, 2024
@miguelvaara
Copy link
Contributor Author

The next step is to prepare this Draft PR for a design review.

It is needed to briefly list what is intended to be demonstrated in the design review and where the focus of the future developement should be directed.

For example, listing languages in the frontend code is unnecessary, as we can directly refer to Skosmos' runtime language, and there are also unnecessary empty spaces in the code ... among other things .. etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant