Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid showing SEO/metadata description on vocab home page #1676

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

osma
Copy link
Member

@osma osma commented Sep 5, 2024

Reasons for creating this PR

It was possible for vocabulary descriptions set in the configuration that were intended for SEO / HTML metadata to be shown on vocabulary home page next to the longer description from the concept scheme metadata:

image

This PR avoids the situation by making the description from the concept scheme override any descriptions defined in the configuration file:

image

Link to relevant issue(s), if any

Description of the changes in this PR

  • when determining the description to show on the vocabulary home page, prefer the description from the concept scheme metadata (it will override the description set in the configuration file)

Known problems or uncertainties in this PR

Probably the same thing, or something similar, needs to be done in Skosmos 3 as well.

No PHPUnit tests, sorry.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the bug label Sep 5, 2024
@osma osma added this to the 2.x milestone Sep 5, 2024
@osma osma requested a review from joelit September 5, 2024 09:57
@osma osma self-assigned this Sep 5, 2024
Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osma osma merged commit d1dd525 into skosmos-2 Sep 5, 2024
4 of 8 checks passed
@osma osma deleted the fix-seo-description-vocab-home branch September 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants