Color selector palette #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devernay
approved these changes
Jan 18, 2022
| this, SLOT( setPaletteButtonColor(bool) ) ); | ||
| QObject::connect( paletteClearButton, SIGNAL( clicked(bool) ), | ||
| this, SLOT( clearPaletteButtons(bool) ) ); | ||
| QObject::connect( addPaletteColorShortcut, SIGNAL( activated() ), |
There was a problem hiding this comment.
I didn't know one could use slots with default arguments, but yes: https://doc.qt.io/qt-5/signalsandslots.html#signals-and-slots-with-default-arguments
|
@YakoYakoYokuYoku I merged this into RB-2.5 but didn't check that it doesn't break the Qt5 build |
|
Everything went well in the build without any issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Adds supports for palette in the color selector and some ui changes/fixes in the widget.
The palette is stored in the Natron settings.
Show a few screenshots (if this is a visual change)
Have you tested your changes (if applicable)? If so, how?
Futher details of this pull request
See #688