27 new resource protocolscifsshares #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-provider-netapp-ontap into 27-new-resource-protocolscifsshares
wenjun666
requested review from
carchi8py,
chuyich and
suhasbshekar
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
suhasbshekar
requested changes
Apr 19, 2024
| --- | ||
| # generated by https://github.com/hashicorp/terraform-plugin-docs | ||
| page_title: "netapp-ontap_protocols_cifs_share_resource Resource - terraform-provider-netapp-ontap" | ||
| subcategory: "protocols" |
There was a problem hiding this comment.
protocols -> Protocols
carchi8py
approved these changes
Apr 23, 2024
chuyich
reviewed
Apr 23, 2024
| ONTAP generates the path dynamically for the connected user and this path is appended to each | ||
| search path to find the full Home Directory path. | ||
| `, | ||
| Optional: true, |
There was a problem hiding this comment.
It seems "path" is required. Can you double check if path is required?
suhasbshekar
approved these changes
Apr 23, 2024
|
I would suggest to have a acc test which only uses minimum configuration to make sure it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.