Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed networking folders. #288

Closed
wants to merge 7 commits into from
Closed

Renamed networking folders. #288

wants to merge 7 commits into from

Conversation

wenjun666
Copy link
Contributor

No description provided.

@wenjun666 wenjun666 linked an issue Sep 10, 2024 that may be closed by this pull request
Review all Modules name prior to 2.0 release #285
Open
chuyich
chuyich requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@chuyich chuyich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change the directory name under the provider from networking to network since the API is network/ip/interfaces and network/ip/route?
Also the file name under internal/interface: networking_xx to network_xxx?

docs/resources/network_ip_interfaces_resource.md Show resolved Hide resolved
chuyich
chuyich approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@chuyich chuyich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the doc comment can be ignored since the syntax is slightly different between github and terraform registry.

@wenjun666 wenjun666 closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhasbshekar suhasbshekar suhasbshekar approved these changes

@chuyich chuyich chuyich approved these changes

@carchi8py carchi8py Awaiting requested review from carchi8py carchi8py is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review all Modules name prior to 2.0 release
3 participants
@wenjun666 @suhasbshekar @chuyich