41 enhancement netapp ontap storage volume need to support import #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carchi8py
requested review from
chuyich,
suhasbshekar and
wenjun666
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
carchi8py
commented
Nov 13, 2023
CHANGELOG.md
Outdated
| @@ -1,4 +1,8 @@ | |||
|
|
|||
| ## 1.1.0 () | |||
| ENHANCEMENTS: | |||
| * **netapp-ontap_storage_volume_resource**: Add support for import ([#72](https://github.com/NetApp/terraform-provider-netapp-ontap/issues/41)) | |||
There was a problem hiding this comment.
this need to be 41
chuyich
reviewed
Nov 14, 2023
| if len(idParts) != 3 || idParts[0] == "" || idParts[1] == "" || idParts[2] == "" { | ||
| resp.Diagnostics.AddError( | ||
| "Unexpected Import Identifier", | ||
| fmt.Sprintf("Expected import identifier with format: attr_one,attr_two,attr_three. Got: %q", req.ID), |
There was a problem hiding this comment.
Shall we update the error message on attr_one,attr_two... with real parameter names? That will help the user know what need to put.
Expected import identifier with format: name,svm_name,cx_proflie_name. Got: xxx
There was a problem hiding this comment.
Yes we should do that.
chuyich
reviewed
Nov 15, 2023
| @@ -164,4 +164,86 @@ Optional: | |||
| - `policy_name` (String) The tiering policy that is to be associated with the volume | |||
|
|
|||
| ## Import | |||
| Import is currently not support for this Resource. | |||
| This resource supports import, which allows you to import existing volumes into the state of this resource. | |||
| Import require a unique ID composed of the volume name, the volume name, separated by a comma. | |||
There was a problem hiding this comment.
"the volume name, the volume name" ?
…age_volume-need-to-support-import
suhasbshekar
approved these changes
Nov 17, 2023
…age_volume-need-to-support-import
carchi8py
deleted the
41-enhancement-netapp-ontap_storage_volume-need-to-support-import
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complete #41