Changed WPF windows to use TextBlocks instead of Labels, added CHANGELOG file #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o allow TextBlock Attached Properties. Added example to NetSparkle.Samples.NetFramework.WPF to show example of changing the font to Italic
…o allow TextBlock Attached Properties. Added example to NetSparkle.Samples.NetFramework.WPF to show example of changing the font to Italic
|
Thanks for your PR. Appreciate it. I don't have a problem with the change from |
|
Thank you for this! Merged in. The Avalonia build was already using Appreciate it! |
|
No problem, always happy to help if I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our application we use theming which changes windows colours and font styles, and we want to push our colour scheme down into the NetSparkle UI's easily.
By changing the text displays to TextBlocks we can just use TextBlock Attached Properties - for example to set a foreground colour or Italic etc.
I have included an example of this in the WPF example project.
I have also added a CHANGELOG.md file to resolve issue #475