Volvo trucks PDP Resource gallery #87 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markovukiceviccn
requested review from
Lakshmishri,
SantiagoHomps-NC,
TomaszDziezykNetcentric,
cogniSyb and
taimurCognizant
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
cogniSyb
requested changes
Nov 17, 2023
Lakshmishri
previously requested changes
Nov 20, 2023
There was a problem hiding this comment.
I think in tablet/mobile view the entire list of videos should be scrollable not the individual row.
@cogniSyb - Am I right ?
This is not clearly described in the ticket and in that regard I would leave it as it is until someone:
|
|
New icon added to video |
|
|
cogniSyb
requested changes
Nov 23, 2023
|
Lakshmishri
force-pushed
the
87-resource-gallery
branch
from
b262344
to
326677f
Compare
|
|
|
|
|
|
cogniSyb
requested changes
Nov 28, 2023
|
|
|
|
|
|
TomaszDziezykNetcentric
suggested changes
Nov 29, 2023
|
|
|
cogniSyb
approved these changes
Nov 30, 2023
|
TomaszDziezykNetcentric
approved these changes
Dec 1, 2023
TomaszDziezykNetcentric
dismissed
Lakshmishri’s stale review
Discussion solved
cogniSyb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #87
Test URLs: