Countdown in hero #66 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case of overflow content, the height expands
taimurCognizant
requested review from
Lakshmishri,
SantiagoHomps-NC,
cogniSyb and
markovukiceviccn
Closed
3 tasks
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
Lakshmishri
reviewed
Nov 22, 2023
cogniSyb
previously requested changes
Nov 22, 2023
|
|
|
|
cogniSyb
requested changes
Nov 27, 2023
cogniSyb
previously requested changes
Nov 27, 2023
|
|
cogniSyb
approved these changes
Nov 28, 2023
TomaszDziezykNetcentric
approved these changes
Nov 28, 2023
|
SantiagoHomps-NC
approved these changes
Nov 29, 2023
|
|
|
cogniSyb
added a commit
that referenced
this pull request
Dec 4, 2023
* add countdown timer in hero block * refactor gaps, UI improvements for all variants * fix button padding for tablet * better text wrapping * fix hero container takes at least the height of the viewport, and in case of overflow content, the height expands * update hero gradient * add variant to right align background in hero * refactor better class names for positioning * fix hero background * add play icon --------- Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
cogniSyb
added a commit
that referenced
this pull request
Dec 12, 2023
* add countdown timer in hero block * refactor gaps, UI improvements for all variants * fix button padding for tablet * better text wrapping * fix hero container takes at least the height of the viewport, and in case of overflow content, the height expands * update hero gradient * add variant to right align background in hero * refactor better class names for positioning * fix hero background * add play icon --------- Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
cogniSyb
added a commit
that referenced
this pull request
Dec 12, 2023
* add countdown timer in hero block * refactor gaps, UI improvements for all variants * fix button padding for tablet * better text wrapping * fix hero container takes at least the height of the viewport, and in case of overflow content, the height expands * update hero gradient * add variant to right align background in hero * refactor better class names for positioning * fix hero background * add play icon --------- Co-authored-by: Syb Wartna <sybren.wartna@cognizant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #66
Test URLs:
I also fixed the height issue with the hero container. On devices with smaller height like iphone SE the text was overflowing the container.