Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement event notifications #68 #269

Merged
merged 35 commits into from
Dec 1, 2023
Merged

Implement event notifications #68 #269

merged 35 commits into from
Dec 1, 2023

Conversation

TomaszDziezykNetcentric
Copy link

@TomaszDziezykNetcentric TomaszDziezykNetcentric commented Nov 27, 2023 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #68

Test URLs:

manuel-vara and others added 23 commits November 9, 2023 14:04
@manuel-vara
Pardot form block - callback response
7c17530
@manuel-vara
Update messages
8f03640
@manuel-vara
Updated with placeholders Thank you & Error messages
a744562
@manuel-vara
Remove debuggers
d64a719
@manuel-vara
Fix linting issues
d8c1ce3
@manuel-vara
More linting fixes
463b13f
@manuel-vara
Styling update Pardot Form block
81e6da4
@manuel-vara
Integrate newsletter form with form handler
e1ea5fa
@manuel-vara
Getting response from form handler
746492e
@manuel-vara
Fix submission action and form handler response
29af0ef
@manuel-vara
Improvements on form selector specificity and response messages
75db3dd
@manuel-vara
Updated msg placeholder.json keys based on newsletter specific feedba…
2d2cc1e 
…ck message
@manuel-vara
PR fixes
38952e0
@manuel-vara
Including honeypot pardot extra field
3271b74
@manuel-vara
Adding aria-hidden attr to honeypot field
f88ce8e
@manuel-vara
removing unnecessary literals
475a6dc
@tdziezykDS
#68 Add event notifications block
66d6f83
@tdziezykDS
#68 Add custom validation
d422d87
@tdziezykDS
#68 Add success and failure messages
6ea35a9
@tdziezykDS
#68 Add error handling for request
7f42bef
@tdziezykDS
#68 Add error handling for request
0fd6723
@tdziezykDS
#68 Update input error state
436e9b4
@tdziezykDS
#68 Add policy element
aec1481
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 27, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@TomaszDziezykNetcentric
Copy link
Author

Screenshot 2023-11-28 at 19 39 09 This gap should 16px in tablet view

Fixed

@TomaszDziezykNetcentric TomaszDziezykNetcentric marked this pull request as ready for review November 29, 2023 12:25
cogniSyb
cogniSyb requested changes Nov 29, 2023
View reviewed changes
blocks/v2-event-notify/v2-event-notify.css Outdated Show resolved Hide resolved
blocks/v2-event-notify/v2-event-notify.css Outdated Show resolved Hide resolved
blocks/v2-forms/forms/event-notify.js Outdated Show resolved Hide resolved
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/pardot-test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cogniSyb cogniSyb changed the title 68 event notifications Implement event notifications #68 Nov 29, 2023
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/pardot-test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 29, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/pardot-test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/pardot-test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/pardot-test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 1, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/pardot-test PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@TomaszDziezykNetcentric TomaszDziezykNetcentric merged commit c190a05 into develop Dec 1, 2023
2 checks passed
cogniSyb pushed a commit that referenced this pull request Dec 4, 2023
@TomaszDziezykNetcentric @cogniSyb
Implement event notifications #68 (#269)
82ba94e 
* Event notifications block #68 

* Calendar invite #72
cogniSyb pushed a commit that referenced this pull request Dec 12, 2023
@TomaszDziezykNetcentric @cogniSyb
Implement event notifications #68 (#269)
c628565 
* Event notifications block #68 

* Calendar invite #72
cogniSyb pushed a commit that referenced this pull request Dec 12, 2023
@TomaszDziezykNetcentric @cogniSyb
Implement event notifications #68 (#269)
b32f113 
* Event notifications block #68 

* Calendar invite #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cogniSyb cogniSyb cogniSyb approved these changes

@SantiagoHomps-NC SantiagoHomps-NC SantiagoHomps-NC approved these changes

@manuel-vara manuel-vara manuel-vara approved these changes

@Lakshmishri Lakshmishri Lakshmishri left review comments

@markovukiceviccn markovukiceviccn Awaiting requested review from markovukiceviccn

@taimurCognizant taimurCognizant Awaiting requested review from taimurCognizant

Assignees

@TomaszDziezykNetcentric TomaszDziezykNetcentric

Labels
FR Functional requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TomaszDziezykNetcentric @Lakshmishri @SantiagoHomps-NC @manuel-vara @cogniSyb @tdziezykDS @taimurCognizant