Merge pull request #343 from mattrjacobs/simplified-command-construction

Added 3 new constructors for common command setup
Netflix · Dec 11, 2014 · 2b0955a · 2b0955a
2 parents 20b81dc + 02ed4bc
commit 2b0955a
Showing 1 changed file with 55 additions and 1 deletion.
diff --git a/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCommand.java b/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCommand.java
@@ -54,14 +54,68 @@ public abstract class HystrixCommand<R> extends AbstractCommand<R> implements Hy
      * @param group
      *            {@link HystrixCommandGroupKey} used to group together multiple {@link HystrixCommand} objects.
      *            <p>
-     *            The {@link HystrixCommandGroupKey} is used to represent a common relationship between commands. For example, a library or team name, the system all related commands interace with,
+     *            The {@link HystrixCommandGroupKey} is used to represent a common relationship between commands. For example, a library or team name, the system all related commands interact with,
      *            common business purpose etc.
      */
     protected HystrixCommand(HystrixCommandGroupKey group) {
         // use 'null' to specify use the default
         this(new Setter(group));
     }
 
+
+    /**
+     * Construct a {@link HystrixCommand} with defined {@link HystrixCommandGroupKey} and {@link HystrixThreadPoolKey}.
+     * <p>
+     * The {@link HystrixCommandKey} will be derived from the implementing class name.
+     *
+     * @param group
+     *            {@link HystrixCommandGroupKey} used to group together multiple {@link HystrixCommand} objects.
+     *            <p>
+     *            The {@link HystrixCommandGroupKey} is used to represent a common relationship between commands. For example, a library or team name, the system all related commands interact with,
+     *            common business purpose etc.
+     * @param threadPool
+     *            {@link HystrixThreadPoolKey} used to identify the thread pool in which a {@link HystrixCommand} executes.
+     */
+    protected HystrixCommand(HystrixCommandGroupKey group, HystrixThreadPoolKey threadPool) {
+        this(new Setter(group).andThreadPoolKey(threadPool));
+    }
+
+    /**
+     * Construct a {@link HystrixCommand} with defined {@link HystrixCommandGroupKey} and thread timeout
+     * <p>
+     * The {@link HystrixCommandKey} will be derived from the implementing class name.
+     *
+     * @param group
+     *            {@link HystrixCommandGroupKey} used to group together multiple {@link HystrixCommand} objects.
+     *            <p>
+     *            The {@link HystrixCommandGroupKey} is used to represent a common relationship between commands. For example, a library or team name, the system all related commands interact with,
+     *            common business purpose etc.
+     * @param executionIsolationThreadTimeoutInMilliseconds
+     *            Time in milliseconds at which point the calling thread will timeout (using {@link Future#get}) and walk away from the executing thread.
+     */
+    protected HystrixCommand(HystrixCommandGroupKey group, int executionIsolationThreadTimeoutInMilliseconds) {
+        this(new Setter(group).andCommandPropertiesDefaults(HystrixCommandProperties.Setter().withExecutionIsolationThreadTimeoutInMilliseconds(executionIsolationThreadTimeoutInMilliseconds)));
+    }
+
+    /**
+     * Construct a {@link HystrixCommand} with defined {@link HystrixCommandGroupKey}, {@link HystrixThreadPoolKey}, and thread timeout.
+     * <p>
+     * The {@link HystrixCommandKey} will be derived from the implementing class name.
+     *
+     * @param group
+     *            {@link HystrixCommandGroupKey} used to group together multiple {@link HystrixCommand} objects.
+     *            <p>
+     *            The {@link HystrixCommandGroupKey} is used to represent a common relationship between commands. For example, a library or team name, the system all related commands interact with,
+     *            common business purpose etc.
+     * @param threadPool
+     *            {@link HystrixThreadPoolKey} used to identify the thread pool in which a {@link HystrixCommand} executes.
+     * @param executionIsolationThreadTimeoutInMilliseconds
+     *            Time in milliseconds at which point the calling thread will timeout (using {@link Future#get}) and walk away from the executing thread.
+     */
+    protected HystrixCommand(HystrixCommandGroupKey group, HystrixThreadPoolKey threadPool, int executionIsolationThreadTimeoutInMilliseconds) {
+        this(new Setter(group).andThreadPoolKey(threadPool).andCommandPropertiesDefaults(HystrixCommandProperties.Setter().withExecutionIsolationThreadTimeoutInMilliseconds(executionIsolationThreadTimeoutInMilliseconds)));
+    }
+
     /**
      * Construct a {@link HystrixCommand} with defined {@link Setter} that allows injecting property and strategy overrides and other optional arguments.
      * <p>