Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine performance hit of getting caller thread stack trace on every command execution #289

Closed
mattrjacobs opened this issue Jul 30, 2014 · 2 comments
Milestone

Comments

@mattrjacobs
Copy link
Contributor

See #195

@benjchristensen
Copy link
Contributor

I'm pretty certain we don't want to do that. Also, as we move towards 1.4 and mostly non-blocking execution, the call stack of the caller becomes less and less useful to capture when an error occurs (as the caller could be anywhere). This issue already exists in 1.3 and earlier where if queue() or observe() are used, an error being thrown capture the caller thread wherever it is, but since it's not blocking on the HystrixCommand the stack is rather meaningless.

We may just want to eliminate this behavior, or if it is thread, it's just something optional to do but not automatic.

@mattrjacobs
Copy link
Contributor Author

Not worth examining. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants