Removed ExceptionThreadingUtility. Stack traces are not helpful in an event-loop world #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… event-loop world.
|
Hystrix-pull-requests #203 SUCCESS |
|
I'm fine with removing it. |
|
👍 on the changes. 👎 on non-deterministic tests that I wrote. |
mattrjacobs
added a commit
that referenced
this pull request
Jan 7, 2015
…tility Removed ExceptionThreadingUtility. Stack traces are not helpful in an event-loop world
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @benjchristensen @KoltonAndrus for review
Issues #289, #290 deal with fixing ExceptionThreadingUtility to correctly attach stack traces (at very high cost). This doesn't seem worthwhile, especially since, even if we did that properly, they would become useless as soon as Hystrix is used in an event-loop system like Netty.