HystrixThreadPool shutdown methods #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, just saw a problem ... HystrixThreadPool.Factory is package private and not exposed publicly and I don't think I want to make it public just for this use case. I need to consider where the right place is for this functionality to be exposed. |
I'm changing the design from the previous commits so it's more abstract and can handle any type of resources needing cleanup, not just threadpools. ReactiveX/RxJava#45
|
@daveray can you review this new updated version? |
benjchristensen
added a commit
that referenced
this pull request
Feb 15, 2013
HystrixThreadPool shutdown methods
|
Looks like the hystrix timer thread also needs to be shut down. See #109 . |
abersnaze
pushed a commit
to abersnaze/Hystrix
that referenced
this pull request
Nov 7, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#102