Deprecate getter and setter for unused collapsingEnabled property in Collapser Setter. #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Collapser Setter.
|
NetflixOSS » Hystrix » Hystrix-pull-requests #441 SUCCESS |
|
Yeah, nice catch, @nluchs . Would be happy to include a deletion in the 2.x branch as well. Thanks! |
|
Sounds good, thanks Matt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be mistaken, but it looks like the "collapsingEnabled" property in HystrixCollapserProperties.Setter doesn't ever get used, which is kind of confusing, since I had assumed it would actually enable/disable collapsing. So I figure a straightforward way to avoid people using it in the future is Deprecation in current versions and removing it 2.x or whatever. Thoughts? I can submit another pull request to remove it from the 2.x branch if that's a good idea.