Move thread completion to end of chain #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2015 16:09
…readExecutingCommand sequence once per command invocation
…rvable chain (Netflix#377) * Both thread pool metrics and the onThreadComplete execution hook now run later * Modified behavior of HystrixCommand.isExecutedInThread() to match the Javadoc (Netflix#448) ** Now this returns true iff the Hystrix thread executed the run() method
|
Hystrix-pull-requests #200 SUCCESS |
mattrjacobs
added a commit
that referenced
this pull request
Jan 7, 2015
…d-of-chain Move thread completion to end of chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread completion events (metrics and hook execution) were firing earlier in 1.4.x, as documented by #377, and discovered via #327. This PR moves them back to the rightful place at the end of the Observable chain. Along the way, 2 unrelated bugs were fixed.
Hystrix.startCurrentThreadExecutingCommand()and the corresponding endAction0were being invoked twice per command. Now they both invoked onceHystrixCommand.isExecutedInThread()was documented to only return true when it actually ran in the Hystrix thread. In practice, it was returning true in the case that it was set up to run in a thread, but got rejected. Fixing this made the implementation of the thread completion straightforward.