Bypass fallback/circuit breaker for BadRequestExceptions from ExecutionHook #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hystrix-pull-requests #207 SUCCESS |
|
On a quick check this looks good. @mattrjacobs can confirm further. Thanks @gerrit-hntschl |
mattrjacobs
added a commit
that referenced
this pull request
Jan 7, 2015
…executionhook Bypass fallback/circuit breaker for BadRequestExceptions from ExecutionHook
|
Yeah, thanks for including the unit test, @gerrit-hntschl! Merging now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
recently introduced Hystrix into an existing codebase and like it a lot. That codebase uses a custom
BusinessExceptionto signal bad user input etc. We would like to automatically wrap theBusinessExceptions into aHystrixBadRequestExceptionto isolate Hystrix-Exception handling and not having to touch all the existing code.However, turning an
Exceptioninto aHystrixBadRequestExceptioninsideHystrixCommandExecutionHook#onRunErrordid not side-step the fallback machinery. This pull request fixes that.Cheers,
Gerrit