Add shutdown hook for WebSphere and checkError() to detect disconnected client #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed client (issue Netflix#346) WebSphere won't shutdown a servlet until after a 60 second timeout if there is an instance of the servlet executing a request. Add a shutdown method to enable a hook to notify Hystrix to shutdown. You must invoke this method at app server shutdown, perhaps from another servlet's destroy() method. Also added explicit checkError() in poller loop to check for disconnected client.
|
Hystrix-pull-requests #234 SUCCESS |
|
Thanks @jboyd! |
mattrjacobs
added a commit
that referenced
this pull request
Jan 20, 2015
Add shutdown hook for WebSphere and checkError() to detect disconnected client
|
This fix does not seem to have fixed the WebSphere issue. "Also added explicit checkError() in poller loop to check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #346
WebSphere won't shutdown a servlet until after a 60 second timeout if there is an instance of the servlet executing a request. Add a shutdown method to enable a hook to notify Hystrix to shutdown. You must invoke this method at app server shutdown, perhaps from another servlet's destroy() method.
Also added explicit checkError() in poller loop to detect disconnected client.