Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded group name when publishing CodaHale metrics fixed #566

Merged
merged 1 commit into from
Jan 25, 2015

Conversation

nurkiewicz
Copy link
Contributor

Currently all commands are published to CodaHale metrics under the same, hard-coded group name "HystrixCommand". Even if I have multiple groups and many commands within them, all commands appear flat under the same name. This PR fixes it by using real group name and building correct metrics hierarchy.

@cloudbees-pull-request-builder

Hystrix-pull-requests #240 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #1 SUCCESS
This pull request looks good

mattrjacobs added a commit that referenced this pull request Jan 25, 2015
Hard-coded group name when publishing CodaHale metrics fixed
@mattrjacobs mattrjacobs merged commit b48de61 into Netflix:master Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants