Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Java7 #577

Merged
merged 5 commits into from
Jan 28, 2015
Merged

Upgrade to Java7 #577

merged 5 commits into from
Jan 28, 2015

Conversation

mattrjacobs
Copy link
Contributor

Addresses #373.

Is this the right way to perform the upgrade w.r.t Gradle? /cc @rspieldenner @quidryan

@cloudbees-pull-request-builder

Hystrix-pull-requests #249 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #10 SUCCESS
This pull request looks good

@mattrjacobs
Copy link
Contributor Author

Merging this now, as it passes all tests. If there's further work around Gradle setup, please open a new issue

mattrjacobs added a commit that referenced this pull request Jan 28, 2015
@mattrjacobs mattrjacobs merged commit f2600f7 into Netflix:master Jan 28, 2015
@mattrjacobs mattrjacobs deleted the java7 branch January 28, 2015 04:58
@rspieldenner
Copy link
Contributor

you don't need the sourceCompatibility and targetCompatibility = 1.7 as those are the defaults but it won't hurt anything

@mattrjacobs
Copy link
Contributor Author

Great, thanks for the confirmation @rspieldenner

@mattrjacobs mattrjacobs mentioned this pull request Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants