Tie command property to thread interrupt #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 6, 2015 13:23
… interruptions Conflicts: hystrix-core/src/test/java/com/netflix/hystrix/HystrixCommandTest.java
…rties to HystrixContextScheduler * There are now 2 varieties of HystrixContextScheduler, 1 that produces Actions which cause thread-interrupts on unsubscription and 1 that produces Actions which never interrupt threads. * The proper Scheduler gets chosen when the subscribeOn is wired into the command flow
|
NetflixOSS » Hystrix » Hystrix-pull-requests #28 FAILURE |
|
There's also an open issue about how to represent thread-interruption in ScheduledActions in RxJava. Relates to ReactiveX/RxJava#2579 |
|
I looked for a few minutes at the failing unit tests in hystrix-javanica and didn't see an obvious reason why they are failing now. I could use some help from those more familiar with hystrix-javanica. Any ideas, @dmgcodevil, @sawano / others? |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #29 SUCCESS |
|
Merging this so I can make forward progress on top of this. Opened up a new issue (#663) to track the Javanica unit tests |
mattrjacobs
added a commit
that referenced
this pull request
Feb 10, 2015
…ad-interrupt-2 Tie command property to thread interrupt
This was referenced Feb 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #354 and #598. I think this causes some Javanica unit tests to fail. Will address those next