Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-3651 Warm COINBASE #4594

Merged
merged 5 commits into from
Sep 28, 2022
Merged

EIP-3651 Warm COINBASE #4594

merged 5 commits into from
Sep 28, 2022

Conversation

smartprogrammer93
Copy link
Contributor

Closes #4585

Changes:

Implement EIP-3651 and move to a better way of doing Fork specs

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

LukaszRozmej
LukaszRozmej reviewed Sep 19, 2022
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests

src/Nethermind/Nethermind.Core/Specs/IReleaseSpec.cs Outdated Show resolved Hide resolved
@dceleda
Copy link
Contributor

dceleda commented Sep 19, 2022

Some of these changes look common to other Shangai EIPs.
If yes then please split it out to separate PR and let's merge it earlier so that others can re-use it.

@smartprogrammer93 smartprogrammer93 marked this pull request as ready for review September 21, 2022 15:22
@MarekM25 MarekM25 mentioned this pull request Sep 23, 2022
Closed
@MarekM25 MarekM25 merged commit f13b0e7 into master Sep 28, 2022
@MarekM25 MarekM25 deleted the EIP-3651-Warm-COINBASE branch September 28, 2022 10:45
Andrew-Pohl pushed a commit to fuseio/nethermind that referenced this pull request Oct 7, 2022
@smartprogrammer93 @Andrew-Pohl
EIP-3651 Warm COINBASE (NethermindEth#4594)
3151259 
* Implementation (tests need writing)

* Tests

* spacing fixes
@gakonst gakonst mentioned this pull request Feb 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

@dceleda dceleda Awaiting requested review from dceleda

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

Assignees
No one assigned
Labels
eip shanghai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EIP-3651: Warm COINBASE
5 participants
@smartprogrammer93 @dceleda @MarekM25 @LukaszRozmej @rubo