Introduce ExecutionPayloadParams concept to be able to better compose… #5932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and validate complex method signatures
12 tasks
LukaszRozmej
requested review from
rubo and
MarekM25
and removed request for
deffrian
…nly' into feature/eip-4844-v3-handles-v3-only-ExecutionPayloadParams
This reverts commit 21c72e4.
flcl42
approved these changes
Jul 14, 2023
LukaszRozmej
commented
Jul 17, 2023
src/Nethermind/Nethermind.Merge.Plugin/EngineRpcModule.Paris.cs
Outdated
Show resolved
Hide resolved
MarekM25
reviewed
Jul 17, 2023
| @@ -43,7 +43,7 @@ public async Task NewPayloadV1_should_decline_post_cancun() | |||
|
|
|||
| ResultWrapper<PayloadStatusV1> errorCode = (await rpcModule.engine_newPayloadV1(executionPayload)); | |||
|
|
|||
| Assert.That(errorCode.ErrorCode, Is.EqualTo(ErrorCodes.InvalidParams)); | |||
There was a problem hiding this comment.
I assume that we should return InvalidParams still here
So if you pass newPayloadV1 with post-cancun timestamp your validation should fail once checking that BlobVersionedHashes are null and it should give you InvalidParams
UnsupportedFork will be when you pass newPayloadV3 with pre-cancun timestamp
There was a problem hiding this comment.
The idea is to show this error if we have Cancun timestamp in V2 and pre-Cancun timestamp in V3
MarekM25
approved these changes
Jul 17, 2023
LukaszRozmej
merged commit eac4723
into
feature/eip-4844-v3-handles-v3-only
60 checks passed
LukaszRozmej
deleted the
feature/eip-4844-v3-handles-v3-only-ExecutionPayloadParams
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and validate complex method signatures
SImplify the code a bit.
Tests are failing but it is problem with tests, need to be fixed in main branch as they might get refactored.