Include characters that need to be url encoded in test suite

NewAgeCZ · Mar 5, 2023 · 53d513f · 53d513f
1 parent 147d50f
commit 53d513f
Showing 1 changed file with 17 additions and 11 deletions.
diff --git a/...test/java/org/springframework/cloud/netflix/eureka/http/AbstractEurekaHttpClientTest.java b/...test/java/org/springframework/cloud/netflix/eureka/http/AbstractEurekaHttpClientTest.java
@@ -20,6 +20,8 @@
 import com.netflix.discovery.shared.Applications;
 import com.netflix.discovery.shared.transport.EurekaHttpClient;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
 
 import org.springframework.http.HttpStatus;
 
@@ -46,9 +48,10 @@ void testCancel() {
 		assertThat(eurekaHttpClient.cancel("test", "test").getStatusCode()).isEqualTo(HttpStatus.OK.value());
 	}
 
-	@Test
-	void testSendHeartBeat() {
-		assertThat(eurekaHttpClient.sendHeartBeat("test", "test", info, null).getStatusCode())
+	@ParameterizedTest
+	@ValueSource(strings = { "test", "test#1.[3.?]!"})
+	void testSendHeartBeat(String instanceId) {
+		assertThat(eurekaHttpClient.sendHeartBeat("test", instanceId, info, null).getStatusCode())
 				.isEqualTo(HttpStatus.OK.value());
 	}
 
@@ -58,10 +61,12 @@ void testSendHeartBeatFourOFour() {
 				.isEqualTo(HttpStatus.NOT_FOUND.value());
 	}
 
-	@Test
-	void testStatusUpdate() {
-		assertThat(eurekaHttpClient.statusUpdate("test", "test", InstanceInfo.InstanceStatus.UP, info).getStatusCode())
-				.isEqualTo(HttpStatus.OK.value());
+	@ParameterizedTest
+	@ValueSource(strings = { "test", "test#1.[3.?]!"})
+	void testStatusUpdate(String instanceId) {
+		assertThat(
+				eurekaHttpClient.statusUpdate("test", instanceId, InstanceInfo.InstanceStatus.UP, info).getStatusCode())
+						.isEqualTo(HttpStatus.OK.value());
 	}
 
 	@Test
@@ -100,10 +105,11 @@ void testGetApplication() {
 		eurekaHttpClient.getApplication("test");
 	}
 
-	@Test
-	void testGetInstance() {
-		eurekaHttpClient.getInstance("test");
-		eurekaHttpClient.getInstance("test", "test");
+	@ParameterizedTest
+	@ValueSource(strings = { "test", "test#1.[3.?]!"})
+	void testGetInstance(String instanceId) {
+		eurekaHttpClient.getInstance(instanceId);
+		eurekaHttpClient.getInstance("test", instanceId);
 	}
 
 }