Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subghz): added Solight TE44 recognition #183

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

m7i-org
Copy link
Contributor

@m7i-org m7i-org commented Aug 14, 2024

What's new

Added the Solight TE44 weather station, with a protocol similar to Auriol HG06061A but with a checksum and different sync values.
Updated the tests as well, including a raw and a decoded capture.


For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality (both manual and unit tests)
  • I've confirmed the bug to be fixed / feature to be stable

Added the Solight TE44 weather station, with a protocol similar to Auriol HG06061A but with a checksum and different sync values.
Updated the tests as well, including a raw and a decoded capture.
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks :D

@Willy-JL Willy-JL merged commit ff0e885 into Next-Flip:dev Aug 22, 2024
2 checks passed
@m7i-org
Copy link
Contributor Author

m7i-org commented Aug 22, 2024

Thanks for fixing the linting, I couldn't get clang-format to work, somehow it didn't recognize some entries in .clang-format...

$ clang-format -i lib/subghz/protocols/solight_te44.h
YAML:28:3: error: unexpected scalar
  Enabled:         true
  ^
YAML:28:3: error: invalid boolean
  Enabled:         true
  ^
Error reading ./.clang-format: Invalid argument

@Willy-JL
Copy link
Member

Might possibly be an older version that you have installed. Flipper includes it in the toolchain, you can do ./fbt format and it should run fine :D

There's also format_py and format_img, or format_all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants