Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OpenDirectory and enable TopBar button #1675

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Jun 24, 2024

Resolves #1588.

Re-uses the same code we have for opening URIs by created a file:// URI. Tested on both Linux and Windows.

It's not the best solution, and I'll probably change this to just use explorer.exe and xdg-open directly, after doing #163.

@erri120 erri120 requested a review from a team June 24, 2024 12:02
@erri120 erri120 self-assigned this Jun 24, 2024
Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.
Got no complaints.

@erri120 erri120 merged commit fd00d0b into Nexus-Mods:main Jun 24, 2024
9 of 10 checks passed
@erri120 erri120 deleted the feat/1588-open-directory branch June 24, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement OpenDirectory OS-Interop method
2 participants